Fix timeout handling in CopilotSession#60
Closed
burkeholland wants to merge 2 commits intogithub:mainfrom
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a memory leak in the sendAndWait method of the CopilotSession class by ensuring the timeout is properly cleared after Promise.race completes. The previous implementation created a timeout but never cleared it when the idle promise resolved first, leaving the timeout callback queued in the event loop.
Changes:
- Added timeout ID tracking to capture the
setTimeoutreturn value - Wrapped
Promise.racein a try-finally block to guarantee timeout cleanup - Added
clearTimeoutcall in the finally block to prevent memory leaks
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
friggeri
requested changes
Jan 21, 2026
Collaborator
friggeri
left a comment
friggeri
left a comment
There was a problem hiding this comment.
@burkeholland thanks for the contribution, this however fails in CI, mind taking another look?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure proper timeout management in the CopilotSession class to confirm the process exists upon closure. Clear the timeout immediately after race completes.